Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability of fs.test.ts; correct TS problems in it. #1481

Closed
weedySeaDragon opened this issue Oct 21, 2023 · 0 comments
Closed

Improve readability of fs.test.ts; correct TS problems in it. #1481

weedySeaDragon opened this issue Oct 21, 2023 · 0 comments
Labels
needs triage Awaiting triage

Comments

@weedySeaDragon
Copy link
Contributor

I recently created a generator and read through quite a few of the tests to learn how to write it and how to write the tests for it.
I think that some of the tests could be made more readable and thus easier for folks to read as specifications.

I'd like to help out with this (assuming it's of value to the project) and along the way also help fix some TypeScript errors in the tests.

As a start, I've worked on fs.test.ts and will submit a PR for it.

(This work is a chore and not really a feature or a bug. I picked the 'feature' issue template since nothing is broken and thus choosing the 'bug' issue template didn't seem right at all.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Awaiting triage
Projects
None yet
Development

No branches or pull requests

1 participant