New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for grunt-coffee task #62
Conversation
I have signed the CLA |
Thanks Blake! On Saturday, 22 September 2012, Blake Blackshear wrote:
Addy Osmani Developer Programs Engineer at Google |
dest: 'app/scripts' | ||
dest: 'temp/scripts', | ||
options: { | ||
bare: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you are asking about the destination or the bare: true.
Do you want the destination be app/scripts?
I have bare: true because that is what matches the old coffee task's output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was asking about the bare: true
.
Having the IIFE is a good thing, and I'm not sure we should remove it, even though it was the previous default.
Any downsides to not including bare: true
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests fail with bare: false
, so we will need to update the coffee test if we make that change.
Dependent on this pull request: yeoman/yeoman#522 |
In this last update, I left off Any reason to use bare? @mklabs @addyosmani |
Updated gruntfiles to support new features with switch to grunt-coffee. Pull request on yeoman needs to be accepted prior to this one.