Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for grunt-coffee task #62

Closed
wants to merge 4 commits into from

Conversation

blakeblackshear
Copy link
Contributor

Updated gruntfiles to support new features with switch to grunt-coffee. Pull request on yeoman needs to be accepted prior to this one.

@blakeblackshear
Copy link
Contributor Author

I have signed the CLA

@addyosmani
Copy link
Member

Thanks Blake!

On Saturday, 22 September 2012, Blake Blackshear wrote:

I have signed the CLA


Reply to this email directly or view it on GitHubhttps://github.com/yeoman/generators/pull/62#issuecomment-8788359.

Addy Osmani

Developer Programs Engineer at Google
Blogger at: http://addyosmani.com
Phone: +44 7771 334170

dest: 'app/scripts'
dest: 'temp/scripts',
options: {
bare: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you are asking about the destination or the bare: true.

Do you want the destination be app/scripts?

I have bare: true because that is what matches the old coffee task's output.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was asking about the bare: true.

Having the IIFE is a good thing, and I'm not sure we should remove it, even though it was the previous default.

Any downsides to not including bare: true ?

// @mklabs @addyosmani

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests fail with bare: false, so we will need to update the coffee test if we make that change.

@blakeblackshear
Copy link
Contributor Author

Dependent on this pull request: yeoman/yeoman#522

@blakeblackshear
Copy link
Contributor Author

In this last update, I left off bare: true
I also updated the yeoman test for coffee compile to pass with the IIFE.

Any reason to use bare? @mklabs @addyosmani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants