Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Proposal: Make use of local/global ESLint config when generating code #941

Closed
designorant opened this issue Jun 6, 2016 · 3 comments
Labels

Comments

@designorant
Copy link

designorant commented Jun 6, 2016

This proposal is trigerred by @jeremyjs message on the FeathersJS Slack:

If I want to modify the feathers generators to follow my style guide, what's the best way to go about it?

Would I be right to think that in theory it should be possible to pass a config that would modify the generated code accordingly? It wouldn't work with all of the rules, but could definitely help with the basics. This could work somewhat low level, or simply by using the --fix argument on the already generated code.

@SBoudrias
Copy link
Member

You can have a pre-processor run over the files before they're committed to disk that would make them follow their styleguide. See Transform output files through streams for more details.

That being said, the main issue you'll have is that eslint don't fix all the issues or the rules inside the eslint config. So would that ever be good enough?

@jeremyjs
Copy link

jeremyjs commented Jun 7, 2016

@SBoudrias: Personally, my use case is as @designorant says, but I'm willing to compromise by providing custom overrides for any files that aren't totally fixed by a preprocessor. The only problem then is keeping my overrides up to date with the latest releases.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2020

This issue is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale label Jan 1, 2020
@github-actions github-actions bot closed this as completed Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants