Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect if the CLI has been installed globally or as a dev dependency #146

Closed
itaisteinherz opened this issue Nov 9, 2018 · 4 comments · Fixed by #132
Closed

Detect if the CLI has been installed globally or as a dev dependency #146

itaisteinherz opened this issue Nov 9, 2018 · 4 comments · Fixed by #132
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@itaisteinherz
Copy link

itaisteinherz commented Nov 9, 2018

Issuehunt badges

When notified to update a CLI, the suggested command the user should run to update the CLI ignores the way the CLI has been installed, e.g. gloablly or as a dev dependency. The suggested command should be adjusted accordingly.

IssueHunt Summary

litomore litomore has been rewarded.

Sponsors (Total: $40.00)

Tips

@itaisteinherz itaisteinherz changed the title Detect if the module has been installed globally or as a dev dependency Detect if the CLI has been installed globally or as a dev dependency Nov 9, 2018
@sindresorhus
Copy link
Member

This was already implemented for npm in 97d0b97. For Yarn, see #132.

@itaisteinherz
Copy link
Author

itaisteinherz commented Nov 13, 2018

This was already implemented for npm in 97d0b97. For Yarn, see #132.

97d0b97 and #132 only detect if the module has been installed globally, not if it was if it was installed as a dev dependency (or any other type of dependency).

I mostly encounter CLIs installed as either global or dev dependencies, and so I think dev dependency detection should be added.
Peer, optional and bundled dependencies are used sometimes but detecting those would probably be unnecessary (since CLIs aren't normally installed as such dependencies).

@IssueHuntBot
Copy link

@IssueHunt has funded $40.00 to this issue.


@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label May 10, 2019
@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels May 30, 2019
@IssueHuntBot
Copy link

@sindresorhus has rewarded $36.00 to @LitoMore. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $4.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants