Warning for empty inputs

[aeschli]

There's now a message when an test input is not provided:

yeoman-test/lib/adapter.js

Line 44 in 373fbb6

const missingAnswerMessage = `yeoman-test: question ${this.question.name} was asked but answer was not provided`;

Unfortunately for us it's a false positive for cases where we allow empty inputs:
https://github.com/microsoft/vscode-generator-code/blob/07ae7522143dd5d32c8d6402eb6274cb8393765e/generators/app/generate-language.js#L66

In our test this.question.type is input, and answer is ""

yeoman-test/lib/adapter.js

Line 37 in 373fbb6

isSet = Boolean(answer);

results in isSet ===false

[mshima]

I don't think this is a bug.

You should pass { tmLanguageURL: '' } answer to yeoman-test in this case.
It should not print the warning due to

yeoman-test/lib/adapter.js

Line 43 in 373fbb6

if (answer === undefined) {

As far as I remember inquirer never returns undefined if the prompt was shown.
So undefined is not a valid answer for that case.

[aeschli]

You should pass { tmLanguageURL: '' } answer to yeoman-test in this case.

That's what I do. https://github.com/microsoft/vscode-generator-code/blob/07ae7522143dd5d32c8d6402eb6274cb8393765e/test/test.js#L444

answer = this.question.default

I probably should set the default to `` as well. But the message is misleading here as the answer was provided.

[mshima]

Ok. It’s a bug.

This assignment should be moved after the warning.

yeoman-test/lib/adapter.js

Line 41 in 373fbb6

answer = this.question.default;

This condition should test if default is undefined too.

yeoman-test/lib/adapter.js

Line 43 in 373fbb6

if (answer === undefined) {

[mshima]

Fixed in 4f466bb