-
-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yo yo inception issue #51
Comments
I think it's related to Inquirer and the Readline Stream not being cleared. I tough this was resolved a while back, but I haven't test it for a case like this one where another generator is called by another one (inception!) Although, the part about the exit message feels odd. |
I got the double exit messages a couple of times. But when just running But, just now I was able to reproduce it and it is exactly the inception thing. Steps:
and at the end it exits the angular generator, exit message (1), and then yo, exit message (2). |
Yikes. Thanks for reporting. If every installed generator shares an npm linked |
I went a little further and let each generator have their own unique copy of |
@stephenplusplus Yeah, I had this kind of issue when using most command line stream project (mute stream, charm, etc). |
This stuff is a little above my head: this stuff So hopefully someone smarter than me can help out with this! |
Hi there, I've reproduced the bug and implemented a fix in Inquirer 0.2.1 (published to NPM) that fixed it on my machine. Although, Yeoman implemented the 0.2 of Inquirer only in 1.0.0-rc. I wonder what the time frame is for the complete release? |
Hey, soooo as I want to make sure this is fixed for everybody, I also pushed the fix on the 0.1.x series. Let me know how it goes for you! |
It seems to be working now @SBoudrias. The two messages at the end remain, but it makes kinda sense since we are exiting 2 yo's. |
Thanks, @SBoudrias! Fixes it for me! 🤘 I'll add something for the double message thingy. |
This was an awesome series of events. First, thanks to @pzi for being patient and reporting the bug, instead of just saying "bah, someone else'll catch it." And of course, thanks to @SBoudrias for chillin' in #yeoman, making yourself available to help, then releasing fixes for all Yo users. It is very appreciated, everyone :) |
No worries @stephenplusplus, my pleasure. Follow & like the work you guys are doing a lot. Also thanks to @SBoudrias for helping me out with other issues. Cheers |
Today, I updated
yo
to1.0.0-rc.1.1
and I really like yo yo.Great stuff @stephenplusplus.
Unfortunately, I now have the one issue that everything that I type during the prompts is output twice.
Example:
Everything is fine until I select a generator and the prompts start:
In some cases it also happened that the "exit message" (Bye from us etc...) appeared twice, too.
I briefly spoke with @SBoudrias about it, he was able to reproduce it.
Currently I am running:
Hope the above helps, otherwise please let me know. I am also on IRC for another while (although it's 2am here in OZ).
Cheers & thanks
The text was updated successfully, but these errors were encountered: