Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doesn't start #602

Closed
joespinoza opened this issue Jun 5, 2024 · 23 comments
Closed

doesn't start #602

joespinoza opened this issue Jun 5, 2024 · 23 comments
Labels
can't reproduce issues which have no information to be reproduced

Comments

@joespinoza
Copy link

the program doesn't open.

I had version 6.4.1 (for windows) and updated to 6.5.0
@yermak
Copy link
Owner

yermak commented Jun 5, 2024

removed the build. will check later today

@yermak
Copy link
Owner

yermak commented Jun 5, 2024

Which build did you use? Just retested Portable version works fine.

@yermak yermak added can't reproduce issues which have no information to be reproduced labels Jun 5, 2024
@joespinoza
Copy link
Author

joespinoza commented Jun 5, 2024 •
edited
Loading

first the "single user", then i tried the "all users" but neither work

@yermak
Copy link
Owner

yermak commented Jun 6, 2024

Could you please check portable version?
I will check installers...

@joespinoza
Copy link
Author

didn't work portable version, neither "single user" 6.5.1

@tschroeder13
Copy link

Hey, had the same issue. Steam app (6..4.1) not starting, switched to GitHub portable release 6.5.1 - same thing here.

@joespinoza
Copy link
Author

Could you please check portable version? I will check installers...

Any update?

@yermak
Copy link
Owner

yermak commented Jun 11, 2024 •
edited
Loading

All works when i test. Could you run app from console and show if there is any error?
And send me log file

@Nepumuk2000
Copy link

Nepumuk2000 commented Jun 11, 2024 •
edited
Loading

Same problem here on Surface Win 11 Pro. The 6.5.1 all users won't start...
6.5.0 doesn't start as well. 6.4.1 starts.

@SeMuh83
Copy link

SeMuh83 commented Jun 12, 2024 •
edited
Loading

Same issue here

6.5.1 all users/portable not working.
Is not starting

6.4.1 is the last release that's working for me

6.4.2 to latest not starting here

Win11 Pro 64 Bit

@fabiwan
Copy link

fabiwan commented Jun 12, 2024

All works when i test. Could you run app from console and show if there is any error? And send me log file

Nothing show from console and logfile is just :
12-06-2024 19:31:26 INFO AudiobookConverter:81 - Initialising application
12-06-2024 19:31:34 INFO AudiobookConverter:81 - Initialising application
12-06-2024 19:32:03 INFO AudiobookConverter:81 - Initialising application
12-06-2024 19:33:54 INFO AudiobookConverter:81 - Initialising application
12-06-2024 19:34:51 INFO AudiobookConverter:81 - Initialising application
12-06-2024 19:35:49 INFO AudiobookConverter:81 - Initialising application
12-06-2024 19:36:27 INFO AudiobookConverter:81 - Initialising application
12-06-2024 19:38:56 INFO AudiobookConverter:81 - Initialising application
12-06-2024 19:40:20 INFO AudiobookConverter:81 - Initialising application
12-06-2024 19:41:25 INFO AudiobookConverter:81 - Initialising application
12-06-2024 19:42:07 INFO AudiobookConverter:81 - Initialising application
12-06-2024 19:42:42 INFO AudiobookConverter:81 - Initialising application
12-06-2024 19:43:27 INFO AudiobookConverter:81 - Initialising application

@SeMuh83
Copy link

SeMuh83 commented Jun 13, 2024

All works when i test. Could you run app from console and show if there is any error? And send me log file

Nothing show from console and logfile is just : 12-06-2024 19:31:26 INFO AudiobookConverter:81 - Initialising application 12-06-2024 19:31:34 INFO AudiobookConverter:81 - Initialising application 12-06-2024 19:32:03 INFO AudiobookConverter:81 - Initialising application 12-06-2024 19:33:54 INFO AudiobookConverter:81 - Initialising application 12-06-2024 19:34:51 INFO AudiobookConverter:81 - Initialising application 12-06-2024 19:35:49 INFO AudiobookConverter:81 - Initialising application 12-06-2024 19:36:27 INFO AudiobookConverter:81 - Initialising application 12-06-2024 19:38:56 INFO AudiobookConverter:81 - Initialising application 12-06-2024 19:40:20 INFO AudiobookConverter:81 - Initialising application 12-06-2024 19:41:25 INFO AudiobookConverter:81 - Initialising application 12-06-2024 19:42:07 INFO AudiobookConverter:81 - Initialising application 12-06-2024 19:42:42 INFO AudiobookConverter:81 - Initialising application 12-06-2024 19:43:27 INFO AudiobookConverter:81 - Initialising application

How to do that on windows?

@fabiwan
Copy link

fabiwan commented Jun 13, 2024

just check logfile in %appdata%\6.5.1\AudioBookConverter.log

@joespinoza
Copy link
Author

31-05-2024 16:24:40 INFO AudiobookConverter:81 - Initialising application
31-05-2024 16:25:07 INFO AudiobookConverter:81 - Initialising application
31-05-2024 16:25:22 INFO AudiobookConverter:81 - Initialising application
31-05-2024 16:25:52 INFO AudiobookConverter:81 - Initialising application
31-05-2024 16:27:14 INFO AudiobookConverter:81 - Initialising application
31-05-2024 16:27:57 INFO AudiobookConverter:81 - Initialising application
31-05-2024 16:32:22 INFO AudiobookConverter:81 - Initialising application

@SeMuh83
Copy link

SeMuh83 commented Jun 14, 2024

Same

12-06-2024 16:25:50 INFO AudiobookConverter:81 - Initialising application
12-06-2024 16:26:29 INFO AudiobookConverter:81 - Initialising application
12-06-2024 16:26:53 INFO AudiobookConverter:81 - Initialising application
12-06-2024 16:28:01 INFO AudiobookConverter:81 - Initialising application
12-06-2024 16:36:30 INFO AudiobookConverter:81 - Initialising application
12-06-2024 16:36:35 INFO AudiobookConverter:81 - Initialising application
13-06-2024 08:49:26 INFO AudiobookConverter:81 - Initialising application
14-06-2024 14:12:20 INFO AudiobookConverter:81 - Initialising application

@fabiwan
Copy link

fabiwan commented Jun 14, 2024

How can we help ? I am not a developer. I cloned the project and installed microsoft-jdk-21.0.3-windows-x64.msi, gradle-8.8-bin.zip, and apache-maven-3.9.7-bin.zip. I asked ChatGPT how to build a Java project, and it told me to run 'mvn clean install', but it crashes because not resolve dependencies

[ERROR] Failed to execute goal on project audiobookconverter: Could not resolve dependencies for project uk.yermak:audiobookconverter:jar:#{APP_VERSION}#: The following artifacts could not be resolved: org.openjfx:javafx-controls:jar:${javafx.platform}:21.0.3 (absent), org.openjfx:javafx-fxml:jar:${javafx.platform}:21.0.3 (absent), org.openjfx:javafx-graphics:jar:${javafx.platform}:21.0.3 (absent), org.openjfx:javafx-swing:jar:${javafx.platform}:21.0.3 (absent), org.openjfx:javafx-media:jar:${javafx.platform}:21.0.3 (absent), org.openjfx:javafx-base:jar:${javafx.platform}:21.0.3 (absent): Could not find artifact org.openjfx:javafx-controls:jar:${javafx.platform}:21.0.3 in github-mvn-repo-ffmpeg-cli-wrapper-snapshot (https://github.com/yermak/ffmpeg-cli-wrapper/raw/mvn-repo/) -> [Help 1]
I think I'm doing something wrong. Could you please provide a mini tutorial on how to build the project on Windows?
Thanks

@yermak
Copy link
Owner

yermak commented Jun 15, 2024

All, considering it's not issue for everyone, I would assume it's something to do with your own settings/environment, maybe you have some new antivirus database, etc.

I will make test build with more detailed logging by default, so we could jointly look for issue

@pegu-oss
Copy link

Hello,

the problem is caused by a locale that is not English.
In this case, a java.util.MissingResourceException occurs in getBundleWithFallback

You can recreate the problem by replacing this line in the start method:
Locale defaultLocale = Locale.getDefault();
through
Locale defaultLocale = new Locale("de", "DE");

@pegu-oss
Copy link

Here is a fix:

private ResourceBundle getBundleWithFallback(Locale locale) {
	ResourceBundle bundle = null;

	ResourceBundle.Control control = ResourceBundle.Control.getControl(ResourceBundle.Control.FORMAT_DEFAULT);

	try {
	   bundle = ResourceBundle.getBundle("locales/messages", locale, control);
	} catch (MissingResourceException e) {
            logger.error("Error getBundle", e);
        }

	return bundle != null ? bundle : ResourceBundle.getBundle("locales/messages", new Locale("en"), control);
    }

@yermak
Copy link
Owner

yermak commented Jun 21, 2024

Here is a fix:

private ResourceBundle getBundleWithFallback(Locale locale) {
	ResourceBundle bundle = null;

	ResourceBundle.Control control = ResourceBundle.Control.getControl(ResourceBundle.Control.FORMAT_DEFAULT);

	try {
	   bundle = ResourceBundle.getBundle("locales/messages", locale, control);
	} catch (MissingResourceException e) {
            logger.error("Error getBundle", e);
        }

	return bundle != null ? bundle : ResourceBundle.getBundle("locales/messages", new Locale("en"), control);
    }

Great thanks! Will release fix today!

@yermak
Copy link
Owner

yermak commented Jun 21, 2024

To all users using locales other then English, as you see I started localisation of the application, as part of resolving issue #530

Here is the file with English texts, I will be happy to accept you suggestions for other languages (surely, I could use translator - but I will not be able to verify it properly)
https://github.com/yermak/AudioBookConverter/blob/development/src/main/resources/locales/messages_en.properties

@fabiwan
Copy link

fabiwan commented Jun 21, 2024 •
edited
Loading

it works for me (6.5.2)
Thank you both!

edit: french windows here, it ask me to download new version from steam, but i don't use steam ;)

@yermak
Copy link
Owner

yermak commented Jun 21, 2024

it works for me (6.5.2) Thank you both!

edit: french windows here, it ask me to download new version from steam, but i don't use steam ;)

All kudos should go to @pegu-oss. I was too busy with a day job to investigate.

@yermak yermak closed this as completed Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
can't reproduce issues which have no information to be reproduced
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@yermak @tschroeder13 @fabiwan @joespinoza @pegu-oss @Nepumuk2000 @SeMuh83