Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More granular BadVersion #77

Open
clarfonthey opened this issue Oct 24, 2022 · 0 comments
Open

More granular BadVersion #77

clarfonthey opened this issue Oct 24, 2022 · 0 comments

Comments

@clarfonthey
Copy link

Right now, code that checks the magic number at the beginning of the file will return BadVersion if the magic number is unexpected for the current method, but what's actually expected depends on the context.

In some cases, the code requires TTF, in others it requires WOFF, and in others it accepts both but will still throw a BadVersion error if the file is something else entirely.

I would recommend converting this error into a WrongFormat error, which contains a field describing what kind of format was detected, if one exists. I would expect this to detect TTF, WOFF/WOFF2, and OTF, and have "unknown" for anything else.

"Unexpected version" implies that there are other versions, but this is kind of misleading, since TTF is always version 1, and if you get something like 0x4F54 you can be relatively certain this is just an OTF font and not TTF version 20308.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants