Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recognise all possible $foo tags, error on unsupported ones #28

Closed
gregwebs opened this issue Nov 19, 2011 · 2 comments
Closed

recognise all possible $foo tags, error on unsupported ones #28

gregwebs opened this issue Nov 19, 2011 · 2 comments
Assignees

Comments

@gregwebs
Copy link
Member

as suggested in the google group: http://groups.google.com/group/yesodweb/browse_thread/thread/abfe006a1573be9d/3ed101295c7fca16?lnk=gst&q=hamlet+foo#3ed101295c7fca16

<ul>
   $for al <- allAuthLevels
       <li>${show al}

However, that fails because it should be $forall, not $for, which causes
the later use of `al' to be undefined.

If this were to fail due to $for being unrecognised, that would be much
better, because it means that version n+m of hamlet files would fail to
compile on version n of hamlet when a new directive has been added. (ie.
better forward compatibility).

@snoyberg
Copy link
Member

Let's implement this in the next major release. Doing so could in theory break existing code (e.g., any line starting with a dollar sign).

@ghost ghost assigned snoyberg Dec 15, 2011
@snoyberg
Copy link
Member

I changed my mind on this, and set up a useful error message as well. I think that should be sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants