New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warp-tls + wai-cors fails in Edge and Safari when Http2 is enabled. #679

Closed
reite opened this Issue Mar 7, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@reite

reite commented Mar 7, 2018

When using warp-tls together with wai-cors a requests using cors will never finish (stuck at pending) in Edge and Safari. In Chrome and Firefox it works as expected. When I disable http2 in warp settings it works.

I have created a minimal example that shows the error. The server code is here:

https://github.com/reite/test-warp-tls/tree/master/server

The server is running and the result can be seen here:

https://warp-tls-test.firebaseapp.com/

Open the link in Edge or Safari and check the network tab in dev tools. In Edge it makes multiple OPTIONS requests that never finish. In Safari there is a Protocol error.

@reite reite changed the title from warp-tls + wai-cors fails on Edge and Safari when Http2 is enabled. to warp-tls + wai-cors fails in Edge and Safari when Http2 is enabled. Mar 7, 2018

@kazu-yamamoto kazu-yamamoto self-assigned this Mar 7, 2018

@kazu-yamamoto kazu-yamamoto added the http2 label Mar 7, 2018

@kazu-yamamoto

This comment has been minimized.

Contributor

kazu-yamamoto commented Apr 20, 2018

I've finally reproduced this issue on my local host.
Let me try to fix it.

@kazu-yamamoto

This comment has been minimized.

Contributor

kazu-yamamoto commented Apr 20, 2018

This is the same problem as #597 and fixed by 1b7a7f8.

@kazu-yamamoto

This comment has been minimized.

Contributor

kazu-yamamoto commented Apr 20, 2018

A new version has been released.
Please close this issue if your problem is gone.

@reite

This comment has been minimized.

reite commented Apr 20, 2018

The issue is indeed gone in IE. I am not able to test in safari but will assume the issue is gone there too. Will leave my server up for a few days if someone want to try it.

Thank you!

@reite reite closed this Apr 20, 2018

@snoyberg snoyberg removed the in progress label Apr 20, 2018

@kazu-yamamoto

This comment has been minimized.

Contributor

kazu-yamamoto commented Apr 20, 2018

Thank you for your report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment