Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warp-tls: Issues with "ability to load TLS credentials from IORefs" #859

Open
bitc opened this issue Oct 21, 2021 · 0 comments
Open

warp-tls: Issues with "ability to load TLS credentials from IORefs" #859

bitc opened this issue Oct 21, 2021 · 0 comments

Comments

@bitc
Copy link

bitc commented Oct 21, 2021

@vdukhovni left some very insightful comments on the pull request Add the ability to load TLS credentials from IORefs:

#806 (review)

The comments were not addressed by the authors of warp-tls, but I believe that that they are valid points that reveal shortcomings in the current implementation. I recommend reading the original comments since it is very well explained. My understanding is that there are 2 issues:

  1. A single IORef should be used instead of multiple IORefs (to avoid race condition by allowing atomic update)
  2. The API should encourage proper use of certificate chains

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant