Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for more wallets #30

Open
burakkaraceylan opened this issue Jan 16, 2022 · 3 comments · May be fixed by #31
Open

Support for more wallets #30

burakkaraceylan opened this issue Jan 16, 2022 · 3 comments · May be fixed by #31
Assignees
@yessGlory17 @burakkaraceylan
Labels
enhancement New feature or request
Projects
Alpha
Milestone
Alpha

Comments

@burakkaraceylan
Copy link

Currently only support is for metamask. More wallet connections are a must.

I've started working on this here https://github.com/burakkaraceylan/nft-marketplace/tree/moar_wallets

I added WalletConnect and intend to add more. I assumed Infura RPC nodes would be used so you have to set REACT_APP_INFURA_KEY environment variable. I also added .env to gitignore.

It would be nice if you design a pop-up page that will open when the user clicks "connect" where he can choose which wallet to connect.
@yessGlory17 yessGlory17 added the enhancement New feature or request label Jan 16, 2022
@yessGlory17 yessGlory17 added this to the Alpha milestone Jan 16, 2022
@yessGlory17
Copy link
Owner

I will open the necessary pop-up page as an issue to connect a wallet. If no one wants to take this job, I will take care of it. Thank you very much for your participation. I look forward to your Pr.

@yessGlory17 yessGlory17 linked a pull request Jan 17, 2022 that will close this issue
Moar wallets #31
Open
@yessGlory17
Copy link
Owner

@all-contributors please add @burakkaraceylan for code.

@allcontributors allcontributors bot mentioned this issue Jan 18, 2022
Merged
@allcontributors
Copy link
Contributor

@yessGlory17

I've put up a pull request to add @burakkaraceylan! 🎉

@yessGlory17 yessGlory17 added this to Done in Alpha Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yessGlory17 yessGlory17

@burakkaraceylan burakkaraceylan

Labels
enhancement New feature or request
Projects
Alpha
Done
Milestone
Alpha
Development

Successfully merging a pull request may close this issue.

Moar wallets burakkaraceylan/nft-marketplace
3 participants
@yessGlory17 @burakkaraceylan and others