Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fails on initial repo clone #42

Closed
CodeRunRepeat opened this issue Apr 23, 2021 · 4 comments
Closed

Build fails on initial repo clone #42

CodeRunRepeat opened this issue Apr 23, 2021 · 4 comments
Assignees
@aheumaier
Labels
documentation Improvements or additions to documentation
Projects
Azure CDK Roadmap
Milestone
First releasable ...

Comments

@CodeRunRepeat
Copy link
Contributor

The initial yarn build on a freshly cloned repo fails since the .generated files in the basic example are missing. To reproduce, clone the repo in a new directory and run yarn build.
You will get

$ tsc
lerna ERR! yarn run build exited 1 in '@examples/basic'
lerna ERR! yarn run build stdout:
$ tsc
index.ts(5,8): error TS2307: Cannot find module './.generated/ContainerInstance'.
index.ts(8,8): error TS2307: Cannot find module './.generated/ContainerRegistry'.

To resolve this, one can change the build script for the example to armkit generate && tsc, or add a new script, e.g. bootstrap that will be used only once, is the same as build for the other packages, and will run armkit generate && tsc for the example. First approach is simpler, but I am not sure what the overhead of running generate each time would be.
@pgollucci
Copy link
Contributor

I agree. I willl have a look.

@pgollucci pgollucci mentioned this issue Apr 26, 2021
Closed
ohthehugemanatee added a commit to ohthehugemanatee/armkit that referenced this issue May 18, 2021
@ohthehugemanatee
Update build instructions in README pending resolution to Yetics#42
af9e569
@ohthehugemanatee ohthehugemanatee mentioned this issue May 18, 2021
Merged
@tomconte tomconte mentioned this issue May 18, 2021
Merged
aheumaier added a commit that referenced this issue May 19, 2021
@aheumaier
Merge pull request #62 from ohthehugemanatee/build-loop
4a24ba4 
Update build instructions in README pending resolution to #42
@aheumaier
Copy link
Collaborator

resolves in #81 that updates yarn task deps

@aheumaier
Copy link
Collaborator

@CodeRunRepeat @tomconte @pgollucci Does th current changes in main resolves this issue ?

@aheumaier aheumaier added this to Researching in Azure CDK Roadmap via automation May 20, 2021
@aheumaier aheumaier added the documentation Improvements or additions to documentation label May 20, 2021
@aheumaier aheumaier self-assigned this May 20, 2021
@aheumaier aheumaier moved this from Researching to Developer Preview in Azure CDK Roadmap May 20, 2021
@aheumaier
Copy link
Collaborator

aheumaier commented May 21, 2021 •
edited

Feel free to reopen if there should be still issues arise

Azure CDK Roadmap automation moved this from Developer Preview to Shipped May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aheumaier aheumaier

Labels
documentation Improvements or additions to documentation
Projects
Azure CDK Roadmap
  
Shipped
Milestone
First releasable armkit prototype
Development

No branches or pull requests
3 participants
@pgollucci @aheumaier @CodeRunRepeat