find_additional_public_hostnames() enhancement for virtual hosts

[lsl-at]

Discussed in #160

^{Originally posted by lsl-at August 24, 2022}
Hi!

I've just migrated my Zimbra host and stumbled upon certbot_zimbra.sh.

While looking through the code I see that find_additional_public_hostnames() queries the property zimbraPublicServiceHostname, as in:

[zimbra@HOST ~]$ zmprov -l gd DOMAIN.COM zimbraPublicServiceHostname
# name domain.com
zimbraPublicServiceHostname: webmail.domain.com

But it should rather be querying the property zimbraVirtualHostname, as in:

[zimbra@HOST ~]$ zmprov -l gd DOMAIN.COM zimbraVirtualHostname 
# name domain.com
zimbraVirtualHostname: webmail.domain.com
zimbraVirtualHostname: mail.domain.com
zimbraVirtualHostname: smtp.domain.com

I would like to patch this function. What do you think about that, or should it be added as another feature?

Regards
Friedl