Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent external API calls on backend instance init #9

Merged
merged 2 commits into from Sep 27, 2013
Merged

Prevent external API calls on backend instance init #9

merged 2 commits into from Sep 27, 2013

Conversation

nossila
Copy link
Contributor

@nossila nossila commented Sep 26, 2013

VimeoBackend and SoundCloudBackend were making API calls right after being instantiated. Change it to prevent API calls until actually needed.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) when pulling a3e4776 on sayadn:remove-api-calls-on-init into e74cc96 on yetty:master.

yetty added a commit that referenced this pull request Sep 27, 2013
@yetty
Merge pull request #9 from sayadn/remove-api-calls-on-init
c2699d5 
Prevent external API calls on backend instance init
@yetty yetty merged commit c2699d5 into jazzband:master Sep 27, 2013
@yetty
Copy link
Collaborator

yetty commented Sep 27, 2013

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nossila @coveralls @yetty