Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UseStateHandle does not implement PartialEq so can't be used as a prop field #2091

Closed
mc1098 opened this issue Sep 28, 2021 · 1 comment · Fixed by #2092
Closed

UseStateHandle does not implement PartialEq so can't be used as a prop field #2091

mc1098 opened this issue Sep 28, 2021 · 1 comment · Fixed by #2092
Labels
A-yew Area: The main yew crate bug

Comments

@mc1098
Copy link
Contributor

mc1098 commented Sep 28, 2021

Problem

Steps To Reproduce
Steps to reproduce the behavior:
Try to use UseStateHandle<T> as a field in a Properties struct - regardless of whether T: PartialEq it will complain that UseStateHandle doesn't implement PartialEq.

Expected behavior
At minimum if T: PartialEq then so should UseStateHandle<T>, however I think we could implement PartialEq even
when T is not PartialEq.

Environment:

  • Yew version: master
@mc1098 mc1098 added bug A-yew Area: The main yew crate labels Sep 28, 2021
@hamza1311
Copy link
Member

This also applies to UseReducerHandle. I'll PR a PartialEq impl for both of them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants