Yew router example main.rs component does not update html at all

[voidpumpkin]

Problem
Yew router example main.rs components does not update html at all on changes

Sadly right now I feel I would spend too much time debugging thus i created this bug report

Steps To Reproduce
Steps to reproduce the behavior:

1. Start yew router example in mobile view
2. click the burger
3. nothing happens

Expected behavior
Menu opens

Screenshots

Environment:

• Yew version: [master]
• Rust version: [1.56.0]
• Build tool, if relevant: [trunk]

Questionnaire

• I'm interested in fixing this myself but don't know where to start
• I would like to fix and I have a solution
• I don't have time to fix this right now, but maybe later

[futursolo]

I think I might be the culprit who broke the router example while updating the router. :)

Would you mind to assign this to me?

[hamza1311]

This seems to happen because the Router re-renders only if two (in this case) BrowserHistory are not equal

yew/packages/yew-router/src/router.rs

Lines 77 to 92 in 1f03a04

	fn changed(&mut self, ctx: &Context<Self>) -> bool {
	let link = ctx.link().clone();
	if self.history != ctx.props().history {
	self._listener = ctx
	.props()
	.history
	.listen(move || link.send_message(Msg::ReRender));
	self.history = ctx.props().history.clone();
	true
	} else {
	false
	}
	}

which is never true (they're always equal):

yew/packages/yew-router/src/history.rs

Lines 155 to 160 in 1f03a04

	impl PartialEq for BrowserHistory {
	fn eq(&self, _rhs: &Self) -> bool {
	// All browser histories are created equal.
	true
	}
	}

[hamza1311]

Would you mind to assign this to me?

Sure, take it