Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for testing examples before 0.19 release #2205

Closed
24 tasks done
voidpumpkin opened this issue Nov 27, 2021 · 11 comments
Closed
24 tasks done

Tracking issue for testing examples before 0.19 release #2205

voidpumpkin opened this issue Nov 27, 2021 · 11 comments
Labels
meta Repository chores and tasks

Comments

@voidpumpkin
Copy link
Member

voidpumpkin commented Nov 27, 2021

Check if passed:

  • counter
  • file_upload
  • futures
  • inner_html
  • keyed_list
  • multi_thread
  • node_refs
  • portals
  • router
  • timer
  • two_apps
  • webgl
  • boids
  • dyn_create_destroy_apps
  • function_todomvc
  • game_of_life
  • js_callback
  • mount_point
  • nested_list
  • password_strength
  • pub_sub
  • store
  • todomvc
  • web_worker_fib
@voidpumpkin voidpumpkin added the meta Repository chores and tasks label Nov 27, 2021
@voidpumpkin
Copy link
Member Author

voidpumpkin commented Nov 27, 2021

dyn_create_destroy_apps is missing live demo but works locally

@voidpumpkin
Copy link
Member Author

multi_thread demo down but seems its supposed to be that way, so I'm marking as pass

@voidpumpkin
Copy link
Member Author

nested_list seems just broken functionality-wise

@voidpumpkin
Copy link
Member Author

web_worker_fib has no live demo but works locally

@voidpumpkin voidpumpkin changed the title Tracking issue for examples testing before 0.19 release Tracking issue for testing examples before 0.19 release Nov 27, 2021
@mc1098
Copy link
Contributor

mc1098 commented Nov 27, 2021

Styling of burger menu on router example is incorrect - probably due to the change of anchor to button.
image
Not that this is a blocker for the release as it just needs some css tweaking

@voidpumpkin
Copy link
Member Author

@mc1098 It actually looks good for me locally, its just not centered, here the centering PR maybe it will update demo properly #2207

@voidpumpkin
Copy link
Member Author

Styling of burger menu on router example is incorrect - probably due to the change of anchor to button. image Not that this is a blocker for the release as it just needs some css tweaking

Maybe its the browser, what browser are you on? I'm using Firefox.

@mc1098
Copy link
Contributor

mc1098 commented Nov 27, 2021

@mc1098 It actually looks good for me locally, its just not centered, here the centering PR maybe it will update demo properly #2207

Oh weird. I use chrome but tried on firefox too and had the same issue as that image but haven't checked the router example locally.

@voidpumpkin
Copy link
Member Author

@mc1098 It actually looks good for me locally, its just not centered, here the centering PR maybe it will update demo properly #2207

Oh weird. I use chrome but tried on firefox too and had the same issue as that image but haven't checked the router example locally.

Nvm i do see it same way as you do in demo. I think my PR will fix it by causing an update.

@voidpumpkin voidpumpkin mentioned this issue Nov 27, 2021
3 tasks
@voidpumpkin
Copy link
Member Author

#2208 Fixes nested list

@mc1098 mc1098 mentioned this issue Nov 27, 2021
3 tasks
@voidpumpkin
Copy link
Member Author

All examples work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Repository chores and tasks
Projects
None yet
Development

No branches or pull requests

2 participants