Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy card should not have a fallback title #695

Open
creotutar opened this issue Apr 17, 2020 · 2 comments
Open

Legacy card should not have a fallback title #695

creotutar opened this issue Apr 17, 2020 · 2 comments

Comments

@creotutar
Copy link
Contributor

Yext answers has been suppressing a title in a result card with title: null since 03/11/2020. Noticing that this suppression is no longer working with the Legacy card, and instead of an empty title, we are defaulting to entity title

example data mappings config

    promotions: {
      card: {
dataMappings: {
title: ""
}
      }
    },

Environment:
using dist/answers-umd.js
v0.13.2

@rosiegrant
Copy link
Contributor

@creotutar what's the use case for having an empty title?

@creotutar
Copy link
Contributor Author

Yext answers use case is a promotional button (and I believe another client is using this in a similar way)
https://answers.yext.com/?query=Free+Trial+of+Yext+Answers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants