Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yxt-Card border for gridded cards surrounding whitespace #782

Open
creotutar opened this issue May 13, 2020 · 1 comment
Open

yxt-Card border for gridded cards surrounding whitespace #782

creotutar opened this issue May 13, 2020 · 1 comment

Comments

@creotutar
Copy link
Contributor

.yxt-Card has styling for a border by default with
border: .0625rem solid #dcdcdc;

When we use a grid for our cards, this makes the cards stretch their height to match the height of the tallest card in the row, which leaves a lot of whitespace for the border to surround.
maxNumberOfColumns: 3,

We should instead put borders on the specific cards (e.g. Product-ProminentImage), or a wrapper for the actual content of the Card.

Env:
sdk 1.0.0
all browsers

@creotutar
Copy link
Contributor Author

For example
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant