Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slug Uniqueness Logic - Scope to features.json instead of entire Knowledge Graph #303

Closed
1 task done
lymarrie opened this issue Apr 21, 2023 · 1 comment
Closed
1 task done
Labels
enhancement New feature or request P1 Highest priority

Comments

@lymarrie
Copy link
Collaborator

lymarrie commented Apr 21, 2023

Description

Currently, during dynamic dev mode, PagesJS validates that each slug value (which powers the getPath function) is unique with respect to the entire Yext Knowledge Graph.

This means, if a Knowledge Graph has two entities with slug = index.html, PagesJS will throw an error; even if one of those entities isn't actually in use for the site during local development. This makes it difficult to use dynamic mode for accounts that may be multi-site (meaning more than one entity will have the same slug).

Suggested solution

Ideally, PagesJS should only validate slug uniqueness against entities defined in features.json, as opposed to the entire Knowledge Graph.

Alternative

No response

Additional context

No response

Validations

  • Check that there isn't already an issue that requests the same feature to avoid creating a duplicate.
@lymarrie lymarrie added enhancement New feature or request pending triage labels Apr 21, 2023
@mkilpatrick mkilpatrick added the P1 Highest priority label May 1, 2023
@benlife5
Copy link
Contributor

Yext CLI issue, not pagesJS
Spruce ticket here

@benlife5 benlife5 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 Highest priority
Projects
None yet
Development

No branches or pull requests

3 participants