Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint: the scripts folder #184

Closed
DavidVujic opened this issue Jul 6, 2019 · 2 comments
Closed

ESLint: the scripts folder #184

DavidVujic opened this issue Jul 6, 2019 · 2 comments

Comments

@DavidVujic
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The JavaScript files in the scripts folder should not be excluded from ESLint.

Describe the solution you'd like
Remove the scripts path from the .eslintignore file.

This will most likely cause issues to be solved in one or more of the files in the scripts folder.

@jbienkowski311
Copy link
Contributor

Why do we exclude lib directory? The whole purpose of eslint is to keep the codebase consistent with defined rules. Maybe we should start from defining eslint rules properly?

@DavidVujic
Copy link
Collaborator Author

DavidVujic commented Jul 6, 2019 via email

@jbienkowski311 jbienkowski311 mentioned this issue Jul 11, 2019
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants