Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce searches for open sessions #66

Closed
Arceliar opened this issue Apr 6, 2018 · 0 comments
Closed

Reduce searches for open sessions #66

Arceliar opened this issue Apr 6, 2018 · 0 comments
Labels
to do Outstanding work required
Milestone

Comments

@Arceliar
Copy link
Member

Arceliar commented Apr 6, 2018

Sort-of related to #65 (but for usage-based resource consumption instead of idle).

Currently, if no traffic has been received for a session in at least 6 seconds, then the next time we send a packet we also start a search. This is to quickly detect if a session has dropped due to coord changes.

What we should do is switch to sending sessionPings (throttled to a max of 1/second/session). If an additional T time (3-6 seconds?) passes without receiving a sessionPong, then try a search instead. Most of the time, a lack of traffic probably just means the session was idle, so a search is overkill.

@Arceliar Arceliar added the to do Outstanding work required label Apr 6, 2018
@Arceliar Arceliar added this to the v0.2 milestone Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to do Outstanding work required
Projects
None yet
Development

No branches or pull requests

1 participant