Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md about FastRunningMedian NaN Handling #2

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

Firionus
Copy link
Contributor

Hey yha 👋,
great job with this package! It seems to do exactly what it says on the box and the implementation is super elegant 👍. I've stumbled across it while searching for my package FastRunningMedian and it was interesting that you also were affected by the garbage output with NaN values. However, as of v0.2.1, FastRunningMedian doesn't output garbage with NaNs anymore 🎉 (tracking issue: Firionus/FastRunningMedian.jl#21).

I've adjusted the README slightly to include this information.

Rock on 😃

As of v0.2.1, FastRunningMedian doesn't output garbage with NaNs anymore 🎉 (tracking issue: Firionus/FastRunningMedian.jl#21). 

I've adjusted the README slightly to include this information.
@yha
Copy link
Owner

yha commented Aug 24, 2023

Thanks 👍
Before writing this package, I looked at FastRunningMedian's algorithm and concluded that it would be too difficult to adapt it to deal with NaNs. But apparently it can be done! 😃

@yha yha merged commit fe2da09 into yha:master Aug 24, 2023
@Firionus
Copy link
Contributor Author

That's funny, I als thought it would be really hard 😂:

Last time I started working on this I remember being so fed up with modifying my complicated algorithm that I explored SkipLists some more instead 😂.
(from the NaN issue)

But once I delved into it, things somehow just fell into place 🤷‍♂️

Have a nice day 🌻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants