Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot update free db due to "Significant Changes to Accessing and Using GeoLite2 Databases" #54

Closed
FabioCareMonkey opened this issue Dec 31, 2019 · 5 comments

Comments

@FabioCareMonkey
Copy link

FabioCareMonkey commented Dec 31, 2019

Since yesterday, this gem can no longer update the GeoLite2 Databases. It will need a few upgrades

this is the reference of what caused this to break
https://blog.maxmind.com/2019/12/18/significant-changes-to-accessing-and-using-geolite2-databases/

@yhirose
Copy link
Owner

yhirose commented Dec 31, 2019

@FabioCareMonkey, thanks for letting me know the news. It seems like I now need to sign up the maxmind user account and get a license key to download test database files and run the unit tests...

@FabioCareMonkey
Copy link
Author

@yhirose Not wanting to place pressure, just to have a fell for it, would you be planing on updating the gem along this January?

@yhirose
Copy link
Owner

yhirose commented Jan 6, 2020

@FabioCareMonkey, I am now thinking of using test data here in https://github.com/maxmind/MaxMind-DB, instead of downloading GeoLite2 databases from their site due to this policy change.

This is actually what the official MaxMind-DB-Reader-ruby does for testing. https://github.com/maxmind/MaxMind-DB-Reader-ruby/tree/master/test

Since the db format itself doesn't change, I don't have to touch the db reader code. All I have to do is just to switch to the new test data. So I think it doesn't take much time to be done. I'll try to work on it sometime this month. Thanks for your attention.

@yhirose
Copy link
Owner

yhirose commented Jan 11, 2020

@FabioCareMonkey, I just started working on the issue.
maxmind/MaxMind-DB-Reader-ruby#32

@yhirose
Copy link
Owner

yhirose commented Jan 12, 2020

Supported the new download policy.
8f06524
7e65191

Since it doesn't require any change in maxminddb gem itself, I don't bump up version.

@yhirose yhirose closed this as completed Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants