Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lots of unused code in Yi.Frontend.Pango.Control #1020

Open
noughtmare opened this issue Aug 4, 2017 · 1 comment
Open

Lots of unused code in Yi.Frontend.Pango.Control #1020

noughtmare opened this issue Aug 4, 2017 · 1 comment
Labels
frontend-pango

Comments

@noughtmare
Copy link
Member

Only the quite trivial keyTable fom Yi.Frontend.Pango.Control is ever used (it is used by Yi.Frontend.Pango. All other functions are never used. Should the module be deleted? In a comment at the top of the file it says that the module isn't finished yet. Is there still a plan to continue it?

Looking through the history it seems like it is just getting in the way when breaking changes are made.

After some more looking around it seems like this module is only used in leksah, maybe they should adopt this code into their codebase?
@ethercrow
Copy link
Member

cc @hamishmack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend-pango
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ethercrow @noughtmare