-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues lazy loading images in gallery #52
Comments
Hi @jweb89 ! Thank you for raising this issue up! 😃 May I know which version of the package are you using? |
Using the latest version which was done from the cloned repo since I had the issue using it as node module with next js. I was also able to sometimes get the next js example repo you provided to produce the issue but it was never consistent. From what I can see the image src isn't getting updated before the image actually tried to be fetched and then it just defaults back to the placeholder/error image |
I see. I had some custom implementation of the lazy loading behaviour in order to support all browsers. I will continue to investigate it. |
Hey. Any news on this ? Im having the same issue. Images load successfully but i got a 404 in console with that "[object%20object]". |
Sorry, I still have not figured out the cause yet. |
I think I fixed the issue in v0.2.7 while fixing issue #51. Please feel free to comment down below if this issue is still there after upgrading. |
Hi ! I just test the v0.2.7 and it seems to be ok now. Good job, thanks ! |
@rhayart Awesome! My pleasure! |
Describe the bug
A clear and concise description of what the bug is.
Sometimes lazy loaded images don't load. From what I can see it doesn't get switched to a real url when swiping or clicking the url so when the image is actually on screen this causes the gallery to try to load the image from https://{path}/[object%20Object]
To Reproduce
Steps to reproduce the behavior:
Not exactly sure how to reproduce consistently, but here is an example
Website has been updated to that issue is no longer present
This is our staging server. The login is dev/dev so you can see the behavior. I tried to do some debugging but couldn't find exactly what was causing the issue. The urls are definitely valid. This doesn't happen if lazy loading is disabled
Expected behavior
A clear and concise description of what you expected to happen.
Should lazy load the image
Screenshots
![image](https://user-images.githubusercontent.com/62513031/127328292-061e58a2-c104-41b6-a7c0-9220d4b87b07.png)
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
This does happen on my iphone as well. See specs above.
The text was updated successfully, but these errors were encountered: