Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slides that have an a-tag inside them aren't clickable on mobile #82

Open
Cyklan opened this issue Jan 19, 2023 · 1 comment
Open

Slides that have an a-tag inside them aren't clickable on mobile #82

Cyklan opened this issue Jan 19, 2023 · 1 comment
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Cyklan
Copy link
Contributor

Cyklan commented Jan 19, 2023

Describe the bug
Let's say I have two slides and both slides have an <a> tag around them. When viewing them on a phone (or the mobile view in a browser) and clicking on them, i won't navigate

To Reproduce

  1. Create a new Gallery that doesn't maximize on click
  2. wrap every slide with an a tag
  3. view on a mobile device (or mobile view in a browser)
  4. click the slide
  5. You won't navigate

Expected behavior
I expect that a tags (and probably buttons, haven't tested those) still work normal when viewing them on mobile

Smartphone (please complete the following information):

  • Device: any
  • OS: any
  • Browser: any
@yifaneye
Copy link
Owner

Hi @Cyklan ! Thank you for raising this issue up.

Regarding

wrap every slide with an a tag

Are you wrapping an <a> tag around one or more block-level elements (e.g. div)? Would you like to paste a simplified version of your code here?

@yifaneye yifaneye self-assigned this Jan 28, 2023
@yifaneye yifaneye added bug Something isn't working help wanted Extra attention is needed labels Jan 28, 2023
@yifaneye yifaneye added this to To do in react-gallery-carousel via automation Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Development

No branches or pull requests

2 participants