Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in container fallback #106

Closed
samdark opened this issue Jul 28, 2021 · 3 comments
Closed

Regression in container fallback #106

samdark opened this issue Jul 28, 2021 · 3 comments
Labels
status:to be verified Needs to be reproduced and validated. type:bug Bug

Comments

@samdark
Copy link
Member

samdark commented Jul 28, 2021

6d03850 introduced a break in fallback logic. While it is necessary for references not to use fallback as in #102, regular dependencies should still use it.

@samdark samdark added type:bug Bug status:ready for adoption Feel free to implement this issue. labels Jul 28, 2021
@samdark
Copy link
Member Author

samdark commented Jul 28, 2021

class Main
{
    public function __construct(LoggerInterface $logger)
    {
        // ...
    }
}

$factory->create(Main::class);

Should create an instance of Main using LoggerInterface instance from container.

@vjik
Copy link
Member

vjik commented Jul 29, 2021

There is no such bug. Regular dependencies use container. Only references don't use fallback to container.
Example with class Main correct work now.

@samdark samdark added status:to be verified Needs to be reproduced and validated. and removed status:ready for adoption Feel free to implement this issue. labels Jul 29, 2021
@samdark
Copy link
Member Author

samdark commented Jul 30, 2021

Verified that it works as expected.

@samdark samdark closed this as completed Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:to be verified Needs to be reproduced and validated. type:bug Bug
Projects
None yet
Development

No branches or pull requests

2 participants