Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code style - chain calls #132

Open
arogachev opened this issue Jul 8, 2022 · 1 comment
Open

Code style - chain calls #132

arogachev opened this issue Jul 8, 2022 · 1 comment
Labels

Comments

@arogachev
Copy link
Contributor

arogachev commented Jul 8, 2022

This is confusing:

$this->assertSame($expected, (string)TestTag::tag()
->class('main')
->class(...$class));

Need to decide whether it's OK:

$this->assertSame($expected, (string)TestTag::tag()->class($class));

@arogachev arogachev added the type:task Task label Jul 8, 2022
@samdark
Copy link
Member

samdark commented Jul 8, 2022

Either it should be the following:

$this->assertSame(
    $expected,
    (string)TestTag::tag() 
        ->class('main') 
        ->class(...$class)
); 

or inline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants