Skip to content
This repository has been archived by the owner on Sep 9, 2019. It is now read-only.

Split ActiveQuery #53

Closed
SamMousa opened this issue Oct 25, 2018 · 1 comment
Closed

Split ActiveQuery #53

SamMousa opened this issue Oct 25, 2018 · 1 comment

Comments

@SamMousa
Copy link
Contributor

Currently yii\db\ActiveQuery operates in 2 contexts (this is documented in the PHPDoc):

  • Normal
  • Relational

This is a violation of the SRP and I don't think there's a need for it.
For example, ActiveQuery class has a $primaryModel property, and a lot of functions change their behavior based on whether or not it is set.

I think we should split this class up into 2 classes, I realize there's some stuff to figure out, that's what this issue is for :)

@ghost
Copy link

ghost commented Oct 25, 2018

This issue was moved by samdark to yiisoft/active-record#2.

@ghost ghost deleted a comment from samdark Oct 25, 2018
@ghost ghost closed this as completed Oct 25, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant