Render now returns ResponseInterface instead of string

[xepozz]

Q	A
Is bugfix?	❌
New feature?	❌
Breaks BC?	❌
Tests pass?	❌
Fixed issues	#52

[schmunk42]

Looks much cleaner!

[roxblnfk]

I think it is wrong that the render method returns a ResponseInterface.
I suggest considering another way.
Let the ActionCaller wrap the string value in a ResponseInterface.

[samdark]

I think it is wrong that the render method returns a ResponseInterface.

I was thinking the same before taking into account that it's controller's render method, not a method of a View.

[roxblnfk]

I think it is wrong that the render method returns a ResponseInterface.

I was thinking the same before taking into account that it's controller's render method, not a method of a View.

It is also worth considering that this controller does not implement MiddlewareInterface, therefore it is not required to return a ResponseInterface. This also applies to other Actions passed to ActionCaller.

[samdark]

Let the ActionCaller wrap the string value in a ResponseInterface.

What if you need headers as well? In case of render() returning ResponseInterface you can add headers after the rendering.

[roxblnfk]

What if you need headers as well? In case of render() returning ResponseInterface you can add headers after the rendering.

Just like now, when we can manually create a Response.

But what if the Action specified in the ActionCaller returns a string rather than ResponseInterface?
What if I want to treat the rendered page as a string? Should I unpack it from Response? (I remind you that ResponseFactory writes a line to a tmp file when creating a stream)
I would be glad to see a separate method like wrapToResponse (), but not so that render transformed it as Response by default

[yiiliveext]

What if I want to treat the rendered page as a string? Should I unpack it from Response? (I remind you that ResponseFactory writes a line to a tmp file when creating a stream)

You still can do it, just render it manually

$content = $this->view->render($view, $parameters, $this);
$bodyText = $this->renderContent($content);

[samdark]

Let's have it. We're likely refactor base controllers in something else anyway: #53

@xepozz thanks!