Add route/list command #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rustamwin
commented
May 7, 2020
rustamwin
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Tests pass? | - |
| Fixed issues | - |
schmunk42
approved these changes
May 7, 2020
yiiliveext
reviewed
May 8, 2020
src/Command/Route/ListCommand.php
Outdated
| $table = new Table($output); | ||
| $io = new SymfonyStyle($input, $output); | ||
| /** @var Route[] $routes */ | ||
| $routes = $this->urlMatcher->getRouteCollection()->getRoutes(); |
There was a problem hiding this comment.
Maybe it will be better to use RouteCollection()->getRouteTree(false) to get routes tree
There was a problem hiding this comment.
@yiiliveext or we need to drop getRouteTree method from RouteCollection instead?
There was a problem hiding this comment.
@yiiliveext or we need to drop
getRouteTreemethod fromRouteCollectioninstead?
Routes tree is more informative and convenient. It is used by the debugger.
There was a problem hiding this comment.
Maybe it will be better to use RouteCollection()->getRouteTree(false) to get routes tree
This is a route table, not a tree.
xepozz
requested changes
May 9, 2020
src/Command/Route/ListCommand.php
Outdated
| $table = new Table($output); | ||
| $io = new SymfonyStyle($input, $output); | ||
| /** @var Route[] $routes */ | ||
| $routes = $this->urlMatcher->getRouteCollection()->getRoutes(); |
There was a problem hiding this comment.
@yiiliveext or we need to drop getRouteTree method from RouteCollection instead?
xepozz
reviewed
May 9, 2020
samdark
added
status:under development
rustamwin
added
status:code review
rustamwin
added
status:code review
xepozz
approved these changes
May 14, 2020
…te-command # Conflicts: # config/common.php
samdark
approved these changes
May 18, 2020
|
Good one. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.