Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middleware factory improving #134

Merged
merged 2 commits into from
Nov 27, 2022
Merged

Middleware factory improving #134

merged 2 commits into from
Nov 27, 2022

Conversation

viktorprogger
Copy link
Contributor

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues

@viktorprogger viktorprogger added the status:code review The pull request needs review. label Nov 27, 2022
@viktorprogger viktorprogger added this to the 1.0.0-alpha1 milestone Nov 27, 2022
@viktorprogger viktorprogger requested a review from a team November 27, 2022 13:36
@viktorprogger viktorprogger self-assigned this Nov 27, 2022
@what-the-diff
Copy link

what-the-diff bot commented Nov 27, 2022

  • Added support for factory definitions in middleware factories.
  • Updated tests to cover new functionality and removed obsolete ones.

@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Base: 81.31% // Head: 80.84% // Decreases project coverage by -0.46% ⚠️

Coverage data is based on head (56c40eb) compared to base (2506620).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #134      +/-   ##
============================================
- Coverage     81.31%   80.84%   -0.47%     
- Complexity      196      201       +5     
============================================
  Files            29       29              
  Lines           487      496       +9     
============================================
+ Hits            396      401       +5     
- Misses           91       95       +4     
Impacted Files Coverage Δ
...rc/Middleware/Consume/MiddlewareFactoryConsume.php 95.45% <100.00%> (-4.55%) ⬇️
src/Middleware/Push/MiddlewareFactoryPush.php 95.45% <100.00%> (-4.55%) ⬇️
src/Queue.php 95.08% <0.00%> (-0.08%) ⬇️
src/Exception/InvalidStatusException.php 0.00% <0.00%> (ø)
...ddleware/InvalidCallableConfigurationException.php 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samdark samdark changed the title Middleware factory imroving Middleware factory improving Nov 27, 2022
@samdark samdark merged commit 376c265 into master Nov 27, 2022
@samdark samdark deleted the middleware-factory-imroving branch November 27, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants