Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests are not compatible with PHP 8 and Codeception 5 #517

Closed
developedsoftware opened this issue Feb 23, 2022 · 1 comment
Closed

Tests are not compatible with PHP 8 and Codeception 5 #517

developedsoftware opened this issue Feb 23, 2022 · 1 comment

Comments

@developedsoftware
Copy link
Contributor

What steps will reproduce the problem?

Run the tests on PHP 8.1 and using Codecept 5

What's expected?

Tests should pass.

What do you get instead?

TypeError: frontend\tests\FunctionalTester::amOnPage(): Argument #1 ($page) must be of type string, array given

Additional info

Propose that all amOnPage() inside tests be changed to amOnRoute so that tests continue to pass.
@developedsoftware
Copy link
Contributor Author

developedsoftware commented Feb 23, 2022 •
edited

This has been actioned in #518

@developedsoftware developedsoftware mentioned this issue Feb 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@developedsoftware