Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What about mysql's 'COMMENT' usage for attributes comments in phpdoc block for a model? #52

Open
djagya opened this issue Jun 7, 2015 · 5 comments
Open

What about mysql's 'COMMENT' usage for attributes comments in phpdoc block for a model? #52

djagya opened this issue Jun 7, 2015 · 5 comments
Labels
type:enhancement Enhancement

Comments

@djagya
Copy link

djagya commented Jun 7, 2015

Not sure about other DB engines.
I can create a PR
@samdark samdark added the type:enhancement Enhancement label Jun 7, 2015
@cebe
Copy link
Member

cebe commented Jun 7, 2015

we already use them for attribute labels, so this should be a radio button selection then.

@djagya
Copy link
Author

djagya commented Jun 7, 2015

and probably some parameter for console command then too?

@cebe
Copy link
Member

cebe commented Jun 7, 2015

isn't console command adopting from the generator automatically?

@djagya
Copy link
Author

djagya commented Jun 7, 2015

ah yes right, sorry

@Faryshta
Copy link
Contributor

i was checking this, the attribute name is generateLabelsFromComments. if we include the option to genereate doc from comments it won't be intuitive by that name, specially for the commands.

i think the best is to make a new option generateDocFromComments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@samdark @cebe @Faryshta @djagya