Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yii\helpers\Console::getScreenSize() on Windows regression #12576

Closed
samdark opened this issue Sep 20, 2016 · 2 comments
Closed

yii\helpers\Console::getScreenSize() on Windows regression #12576

samdark opened this issue Sep 20, 2016 · 2 comments
Assignees
@samdark
Labels
severity:important type:bug Bug
Milestone
2.0.10

Comments

@samdark
Copy link
Member

samdark commented Sep 20, 2016 •
edited

Reported by @karakum: 8a9c8a8

On my system mode con output in RU locale:

Microsoft Windows [Version 6.3.9600]
(c) Корпорация Майкрософт (Microsoft Corporation), 2013. Все права защищены.

d:\>mode con

Состояние устройства CON:
--------------------------
    Строки:                3000
    Столбцы:               225
    Скорость клавиатуры:   27
    Задержка клавиатуры:   0
    Кодовая страница:      866

So current code DON'T WORK
@samdark samdark added this to the 2.0.10 milestone Sep 20, 2016
@samdark
Copy link
Member Author

samdark commented Sep 20, 2016 •
edited

So it seems we can't rely on names and should only rely on CON, : and line number.

@samdark
Copy link
Member Author

samdark commented Sep 20, 2016

When fixed there should be a comment added noticing the reason for not using names.

@samdark samdark self-assigned this Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samdark samdark

Labels
severity:important type:bug Bug
Projects
None yet
Milestone
2.0.10
Development

No branches or pull requests
1 participant
@samdark