Reset dirty attributes after afterSave

[ztdan4ik]

In 2014 @cebe have commit changes for this issue #2892 f439520
So, that _oldAttributes can be used in afterSave() method
But now, as I can see it's not working and according framework source _oldAttributes reset before afterSave()

yii2/framework/db/BaseActiveRecord.php

Line 776 in 88f2348

$changedAttributes = [];

[cebe]

what exactly is the problem?

[ztdan4ik]

For example:

class Customer extends ActiveRecord
{
    /**
     * @return string the name of the table associated with this ActiveRecord class.
     */
    public static function tableName()
    {
        return 'tbl_customer';
    }

    /**
     * @inheritdoc
     */
    public function afterSave($insert, $changedAttributes)
    {
        parent::afterSave($insert, $changedAttributes);

        if ($this->isAttributeChanged('status')) {
            die('PROFIT!');
        }
        die('FU** THIS SHIT!');
    }
}

In afterSave $this->isAttributeChanged('status') return false, even if status has changed.

[cebe]

you can use array_key_exists('status', $changedAttributes). That is the reason this parameter is provided.

[ztdan4ik]

Ok, that's good. Thanks, @cebe ! But this solution is useless in behavior for EVENT_AFTER_INSERT and EVENT_AFTER_UPDATE

For example:

class TimeLineCommand extends Behavior
{

    public function events()
    {
        return [
            ActiveRecord::EVENT_AFTER_INSERT => 'afterSave',
            ActiveRecord::EVENT_AFTER_UPDATE => 'afterSave',
        ];
    }

    public function afterSave($event)
    {
        if ($this->owner->isAttributeChanged('status')) {
            die('PROFIT!');
        }
        die('FU** THIS SH**!');
    }

}

Here is no $changedAttributes :(

[cebe]

it is in $event: http://www.yiiframework.com/doc-2.0/yii-db-aftersaveevent.html#$changedAttributes-detail

[ztdan4ik]

@cube You are my hero!
Sorry for disturb

[vaso2]

Hi there! Any plans for refactoring this behavior? In my case, changedAttributes usage need a lot of duplicated code, checks etc.
For example, I need to send an email about some connected data, when at least one field changes (example: from_time - to_time pair):
lots of complexity just to check if there is at least one changed attribute, then again for every field when trying to determine previous value ($this->getOldAttribute("field") returns current one if unchanged, $event->changedAttributes is array, so when key is not set...)
So, while current design choice seems strange to me, maybe It's just too rare use case?
Thanks for making this awesome framework even better!

[samdark]

Not in Yii 2.0 but could be done in https://github.com/yiisoft/active-record. Please post your suggestions in an issue there. Thanks.