Unknown scenario exception

[borodulin]

yii2/framework/base/Model.php

Lines 356 to 358 in 001e4c5

	if (!isset($scenarios[$scenario])) {
	throw new InvalidArgumentException("Unknown scenario: $scenario");
	}

Why do we need such an exception?

I have model

class Contact extends \yii\db\ActiveRecord
{
    const SCENARIO_CREATE = 'create';
    const SCENARIO_UPDATE = 'update';

    public static function tableName()
    {
        return 'contact';
    }

    public function rules()
    {
        return [
            [['name'], 'required'],
            [['manager_id', 'type_id', 'ownership_id'], 'integer'],
            [['phones'], 'validatePhones', 'on' => self::SCENARIO_CREATE],
            [['manager_id'], 'validateManager', 'skipOnEmpty' => false, 'on' => self::SCENARIO_UPDATE],
        ];
    }
}

And I have Rest Controller

class ContactController extends \yii\rest\ActiveController
{

    public $modelClass = 'common\models\Contact';

    public $createScenario = Contact::SCENARIO_CREATE;
    public $updateScenario = Contact::SCENARIO_UPDATE;`
}

If I need to disable validator on "manager_id" field in Contact model, then I have to remove $updateScenario from ContactController. It seems to me it is not convenient.

I wish to create a basic Controller class with predefined scenarios and use these scenarios in models whenever I want, but now it is impossible.

[mgrechanik]

Why do we need such an exception?

because it is logical.

[borodulin]

it is not logical.

[rob006]

You want to use scenario that is unsupported by model?

[borodulin]

I think that there is no need to generate an exception if the model does not support the scenario, or it should be customizable.

[rob006]

Using unsupported feature does not make sense and should throw exception - it is usually unintended configuration error or simple typo. Ignoring this is not an option, it will hide errors and make debugging much harder.

You can always override scenarios() to return all defined scenarios, even if there are no rules for them. Or just change scenario name:

const SCENARIO_UPDATE = self::SCENARIO_DEFAULT;