Re-init component on fly

[MUTOgen]

Is it possible to modify some components on fly in modules?

I try something like this:

\Yii::$app->set('errorHandler',array(
                'class'=>'app\components\ApiErrorHandler',
                'errorAction'=>'site/error',
            ));

But object of errorHandler doesn't change (it's \yii\web\ErrorHandler by default)

[cebe]

The docs of set() say:

If a component definition with the same ID already exists, it will be overwritten.

this is not the case atm. @qiangxue looks like a bug to me, right?

[qiangxue]

Nope. This is because errorHandler is specially handled in application. The error handler has to be created and registered.

[MUTOgen]

@qiangxue once created errorHandler object will be returned by ServiceLocator always...
Is there fancy way to overwrite?

[qiangxue]

You may try the following. However you probably need to override register() to properly handle the problem of registering multiple exception handlers.

$handler = new \app\components\ApiErrorHandler;
\Yii::$app->set('errorHandler', $handler);
$handler->register();

[cebe]

@qiangxue have you checked the implementation of ServiceLocator? once you have accessed a component, get() will never return a new one that may have been registered with set()
you have to call clear() before setting a new component. Is this expected? if yes, docs should be adjusted.

[qiangxue]

@cebe You are right. I have fixed the issue. However, the issue reported here is different. It's because of the special handling at : https://github.com/yiisoft/yii2/blob/master/framework/base/Application.php#L305

[MUTOgen]

@qiangxue i have PHP Fatal Error

Class 'app\components\Yii' not found

right after calling

$handler->register();

[cebe]

@MUTOgen this looks like you are using Yii without importing it in the namespace. add use Yii; to the class file or use \Yii instead.

[cebe]

@qiangxue yes, I know. See also #3431 working on a fix for that right now.

[MUTOgen]

@cebe importing doesn't work.... i guess it's because of dealing with register();
looks like somewhere inside \Yii class uses without \

[cebe]

can you please post the full error stack trace?

[MUTOgen]

@cebe looks pretty "simple"

<response>
<type>yii\base\ErrorException</type>
<name>PHP Fatal Error</name>
<message>Class 'app\components\Yii' not found</message>
<code>1</code>
<stack-trace>
<item>#0 {main}</item>
</stack-trace>
</response>

[cebe]

have you made any changes to app index.php? if yes, show the whole file please.

[MUTOgen]

No, i didn't
Ctrl+C Ctrl+V

// comment out the following two lines when deployed to production
defined('YII_DEBUG') or define('YII_DEBUG', true);
defined('YII_ENV') or define('YII_ENV', 'dev');

require(__DIR__ . '/../vendor/autoload.php');
require(__DIR__ . '/../vendor/yiisoft/yii2/Yii.php');

$config = require(__DIR__ . '/../config/web.php');

(new yii\web\Application($config))->run();

[MUTOgen]

When i comment line

$handler = new \app\components\ApiErrorHandler;
        \Yii::$app->set('errorHandler', $handler);
        //$handler->register();

There is no fatals

[cebe]

where is this line? in which file?

[MUTOgen]

 public function init()
    {
        parent::init();

        $handler = new \app\components\ApiErrorHandler;
        \Yii::$app->set('errorHandler', $handler);
        //$handler->register();
    }

It's init in module class

[MUTOgen]

now this option to overwrite handler works for me in module init method

$handler = new \app\components\ApiErrorHandler;
        \Yii::$app->set('errorHandler', $handler);
        $handler->register();