Implement TextHighlighter

[qiangxue]

Should we provide it in the core?

[resurtm]

Geshi proposal: yiisoft/yii#1004

[resurtm]

Don't know whether it makes sense, but IMHO it makes: how about implementing client side highlighter too? There is very impressive highlight.js (1, 2).

Just an abstract idea: we could create some kind of a universal highlighter with almost seamless switching between server (GeSHi) and client (highlight.js) side modes. I'm interested in your opinions about this idea.

(Will do investigations on the possibility of doing that.)

[cebe]

Why would someone want to highlight code on client side?
The only reason I can imagine is highlighting input of textarea when you enter code, but all display can be rendered by the server without taking browser performance...

[mdomba]

on the other side, by using a client highlighter the content passed from server to the client is clear text i.e. smaller (faster)... and it saves server performance :D

[cebe]

Server is far more powerfull than client in most cases and when using a javascript there is always a lag seen by the user until loaded dom is manipulated by highlighter.
Can't find any pro arguments...

http://stackoverflow.com/questions/70169/how-to-highlight-source-code-in-html

Also some comments from: http://www.hanselman.com/blog/BestCodeSyntaxHighlighterForSnippetsInYourBlog.aspx

a) it supposes that you have JS on (not always the case, especially when using NoScript)
b) it doesn't work in Google Reader (and possible other feedreaders)

...

Don't you think it's a little lame to not show the syntax highlighting to feed readers? That seems like an
incomplete solution. I had no idea you were using any special syntax highlighting until I visited this post.

[klimov-paul]

Client side hightlighting can be usefull while creating preview. It allows to see how the message will look like without triggering the server with Ajax.
Although client side highlighting has lot of problems. GitHub, for example, does not bother with it and simply uses Ajax.

[yiidevelop]

I have used CTextHighlighter on yii 1.1 and it very good.
If @qiangxue dont implement TextHighlighter to yii2 then i must copy same widgets as CFilterWidget, COutputProcessor, CTextHighlighter to my app/extension and restyle with yii2.

I feel it is inconvenient because I'm not the author of those widgets and i need to use it on yii2

@qiangxue plz, review and implement those

Thanks

[samdark]

I've provided a list in #47 Will be great to get some opinions.

[yiidevelop]

@samdark
yii\helpers\Markdown "Markdown provides an ability to transform markdown into HTML."
It have not yet support TextHighlighter

[samdark]

https://github.com/scrivo/highlight.php is still a good solution for it.

[cebe]

not sure if we really need support for it in the core... maybe better create it as an official extension?
In general I think we have a bit too many things in the core which solve only very specific use cases.
Imo we should use 2.1 to clean up in this regard a little bit.

[samdark]

I was thinking about highlighting of error pages / debug and apidoc rendered pages. Not sure it can be done w/o requiring more code in the core.

[cebe]

okay, makes sense.

[dynasource]

as can be concluded from this discussion, it can be a whole architecture on its own. Out of the cores scope.