Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug toolbar is not shown on PHP errors #7616

Open
cebe opened this issue Mar 7, 2015 · 3 comments
Open

Debug toolbar is not shown on PHP errors #7616

cebe opened this issue Mar 7, 2015 · 3 comments

Comments

@cebe
Copy link
Member

cebe commented Mar 7, 2015

The problem is that ErrorHandler does not use application view in this case:
https://github.com/yiisoft/yii2/blob/master/framework/web/ErrorHandler.php#L220

But toolbar is only rendered on view end body event:
https://github.com/yiisoft/yii2/blob/master/extensions/debug/Module.php#L122

@samdark do you remember why app view is not used on PHP error?

We might fix this by adding a similar event to the errorhandler.

@cebe cebe added the type:bug Bug label Mar 7, 2015
@cebe cebe added this to the 2.0.x milestone Mar 7, 2015
@cebe cebe added the ext:debug label Mar 7, 2015
@samdark
Copy link
Member

samdark commented Mar 7, 2015

I think it's a safeguard for the case when there's an error somewhere in View layer. Adding event seems like a good solution for it.

@yii-bot
Copy link

yii-bot commented Jan 24, 2016

Issue moved to yiisoft/yii2-debug#80

@yii-bot yii-bot closed this as completed Jan 24, 2016
@cebe
Copy link
Member Author

cebe commented Feb 25, 2016

reopening as the fix needs a framework change.

@cebe cebe reopened this Feb 25, 2016
@cebe cebe added this to the 2.0.x milestone Feb 25, 2016
@samdark samdark modified the milestones: 2.0.16, 2.0.x Sep 3, 2017
@samdark samdark removed this from the 2.0.17 milestone Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants