Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about dataset construction #16

Closed
LeePleased opened this issue Aug 2, 2019 · 2 comments
Closed

Question about dataset construction #16

LeePleased opened this issue Aug 2, 2019 · 2 comments

Comments

@LeePleased
Copy link

Hello Yikang:

Hi~, I'm a research intern of HIT-SCIR lab, Yangming Li. It's great for your contribution about this repository. But I found some problems about the dataset construction (including test set):

1, the use of pytorch API "narrow" will unexpectedly abandon some words and result in incorrect PPL score.

2, It seems that your slide window on the whole corpus is not continuous and thus generate far less data than usual.

Great thanks again for your contribution about this repository.
Yangming, 19/08/02

@yikangshen
Copy link
Owner

Hi Yangming,
The problems that you mentioned are actually regularization methods introduced in AWD-LSTM (https://github.com/salesforce/awd-lstm-lm). Please refer to their paper for explanations.

@LeePleased
Copy link
Author

Very thanks for your response :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants