Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plz update for gnome 46 im begging you #158

Open
EisregenHaha opened this issue Mar 21, 2024 · 28 comments
Open

Plz update for gnome 46 im begging you #158

EisregenHaha opened this issue Mar 21, 2024 · 28 comments

Comments

@EisregenHaha
Copy link

i love ur work and this extension so much my desktop is unusable without it plz update im on my knees i can send feet pics please i need this

@Neo-29
Copy link

Neo-29 commented Mar 24, 2024

Confirmed breakage

It even makes the session fail when opening google chrome for example.

@lucentxo
Copy link

This project is pretty much abandoned, I wouldn't get your hopes up unless a fork comes along.

@EisregenHaha
Copy link
Author

This project is pretty much abandoned, I wouldn't get your hopes up unless a fork comes along.

there is already a fork fixing it, quick dorty fix which isnt the right way according to the fork author but eh, if it works it works and i couldnt live without it fr

@prastowoagungwidodo
Copy link

You can try this fix: #156 (comment)
May be not best solution, but, yeah, its works

@EisregenHaha
Copy link
Author

You can try this fix: #156 (comment) May be not best solution, but, yeah, its works

i already did and im in that thread already lol, but thanks anyway

@prastowoagungwidodo
Copy link

Hahaha
OMG, Im sorry, I didn't realize that you're the thread starter 😂

@EisregenHaha
Copy link
Author

``

Hahaha OMG, Im sorry, I didn't realize that you're the thread starter 😂

im actually not, i just asked the person to link to their fork which already has the fix applied lol, that way no need to do it myself yk. im just there in the comments

@ryzendew
Copy link

ryzendew commented Apr 9, 2024

This project is pretty much abandoned, I wouldn't get your hopes up unless a fork comes along.

what do you mean ?

@yotamguttman
Copy link

@ryzendew he means that the author stopped supporting this project and its most recent compatibility was with Gnome 44 whereas now we've already got Gnome 46. so you have no reason to count on using this extension, as it is no longer maintained.

@MartinHaeusler
Copy link

Would love to have this on gnome 46 too. Ubuntu 24.04 LTS has it for all system windows, but for all other applications it's still the square corners, which makes it look inconsistent and weird.

@yotamguttman
Copy link

totally get you... we've gotta wait until someone euther clones this code or writes a new extension...

@flexagoon
Copy link
Contributor

You can install my fork which contains a proper fix

https://github.com/flexagoon/rounded-window-corners

However, the bug with workspace switching still occurs if you have blur my shell installed

@flexagoon
Copy link
Contributor

Quoting from #156:

This should most likely be fixed on the Blur My Shell side. I'll try to come up with a fix and submit a PR. Until then, I made a temporary solution which fixes the issue.

I don't see any bugs left with my fork, so feel free to use it. I'll submit it to EGO once the blur-my-shell issue is properly resolved (and unless @yilozt comes back by then)

@yotamguttman
Copy link

cheers @flexagoon !
currently what I'm seeing is that the installation instructions are for the old extension (by @yilozt) anyway.

will wait for you to upload it officially. what will you call the extension once it's available? so that I'll be able to find it on EGO's search?

@flexagoon
Copy link
Contributor

@yotamguttman it's not on EGO yet, but you can still build and install it, the instructions are in the readme, you just run yarn install && yarn ext:install

I don't know what I'll call it, but it'll probably contain the original name so that people could find it easily, so something like "Rounded Window Corners Reborn" or "Rounded Window Corners 2"

@irvng-wav
Copy link

@flexagoon you're golden. Thank you for keeping this extension alive and for working to fix the Blur My Shell bug! I'm truly grateful.

@MartinHaeusler
Copy link

@flexagoon I checked out your repo and ran yarn install && yarn ext:install, and that worked, but when I try to enable the extension, my ubuntu (24.04) tells me:

The installed version of this extension (12) is incompatible with the current version of GNOME (46.0). The extension has been disabled.

Do you have any advice? Am I doing something wrong or am I missing something?

@flexagoon
Copy link
Contributor

@MartinHaeusler please see the readme in my repo. I changed the installation instructions.

@MartinHaeusler
Copy link

@flexagoon thank you, works like a charm when installed from your latest CI output. Love it!

@flexagoon
Copy link
Contributor

i can send feet pics please i need this

@EisregenHaha still waiting for the feet pics

@EisregenHaha
Copy link
Author

i can send feet pics please i need this

@EisregenHaha still waiting for the feet pics

offer wasnt directed at you 🙅 (huge thanks for maintaining it now though, saving my desktop)

@flexagoon
Copy link
Contributor

talk about thankless open-source maintainers.... 😔

you're welcome though.

@yotamguttman
Copy link

thanks for making it happen @flexagoon !
can't wait for you to put it up on EGO :)

@flexagoon
Copy link
Contributor

@yotamguttman it'll be on EGO once the next version of Blur My Shell is released which will contain a proper fix for the gnome shell freeze

@yotamguttman
Copy link

amazing thank you! 🙏 @flexagoon

@MartinHaeusler
Copy link

Any news on a official release? Unfortunately the built artifacts are gone, I assume github deletes them after a while.

@flexagoon
Copy link
Contributor

@MartinHaeusler the extension is pending review

https://extensions.gnome.org/review/55303

I'm able to download the CI artifact just fine though, doesn't seem like it's deleted

@yotamguttman
Copy link

yotamguttman commented Jun 7, 2024

hey @flexagoon! could I try to contribute an icon for the EGO listing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants