Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border color based on theme. #97

Open
aaronrancsik opened this issue Dec 4, 2022 · 2 comments
Open

Border color based on theme. #97

aaronrancsik opened this issue Dec 4, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@aaronrancsik
Copy link

aaronrancsik commented Dec 4, 2022

Hi,
First of all nice extension, thanks!

I have the idea to define 2 border color 1 for dark and 1 for light mode as well and use them based on the following solutions.

  1. Easy solution: choose the border color around the application based on Gnome's built-in dark / light mode settings.
    I would keep it as a fallback option for certain applications if the 2. method not feasible.

Reason for this next solution:
Gnome's dark mode is just a preferred theme, but every application can override it for good. (For example an IDE always dark no matter what)

  1. Somehow (I've done no research so maybe it's not possible) query from gnome for every application the current mode, dark or light.
    Choose the border color based on this information for every application.
    Use the first solution as fallback option if it's not possible for an application.

Cheers

@CodeAndGin
Copy link

I would like to bump this with the added suggestion to have an active border colour and an inactive border colour. The current gtk theme I'm using has this behaviour, and this extension overwrites it.

@yilozt yilozt added the enhancement New feature or request label Dec 19, 2022
@ceiphr
Copy link

ceiphr commented Dec 26, 2022

Hello!

I've found an interesting work-around to sort-of address this.

Here's a command that can change border color:

gsettings --schemadir ~/.local/share/gnome-shell/extensions/rounded-window-corners@yilozt/schemas set org.gnome.shell.extensions.rounded-window-corners border-color '(0.81176471710205078, 0.81176471710205078, 0.81176471710205078, 1.0)'

The last bit is the actual color. To get a value you want, set it in the extension's settings, then find it in the dconf-editor at this location:

/org/gnome/shell/extensions/rounded-window-corners/

Replace your preferred color in the command with the one found there under border-color, and voilà!

Currently, I use this work around with the Night Theme Switcher extension, so the border color respects my system theme.

With that being said, I'd absolutely love to see the custom window setting have support for border colors. That would help with applications that only have dark themes when the border color is set for a light theme:

Screenshot from 2022-12-26 13-56-23

This would help a ton, like how the Dark Variant extension can make title bars dark for windows that should really be dark, even on light themes (I'm looking at you Spotify).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants