Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scanning for js files #6

Open
kriby opened this issue Sep 13, 2019 · 2 comments
Open

Add scanning for js files #6

kriby opened this issue Sep 13, 2019 · 2 comments

Comments

@kriby
Copy link

kriby commented Sep 13, 2019

Hi,

Are there any plans to extend the functionality of this module for js files also?

    'jquery',
    'Magento_Checkout/js/model/quote'
], function ($, quote) {
    'use strict';

I believe in this case Magento_Checkout dependency should be added.

thanks

@jissereitsma
Copy link
Contributor

There is no direct planning for this as this is just a hobby project that receives some free time so now and then. However, indeed the plan was to incorporate this as well. Also, if a folder etc/adminhtml would be there, a module Magento_Backend is probably needed.

@jissereitsma
Copy link
Contributor

There is a new architecture in place that facilitates scanning for JS files anyway. I might be adding this soon, but I just wanted to mention it already here: https://github.com/yireo/Yireo_ExtensionChecker/blob/master/ComponentDetector/JsComponentDetector.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants