Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What needs to be done in order to consider this module stable? #10

Open
tylers-username opened this issue May 9, 2019 · 1 comment
Open

Comments

@tylers-username
Copy link

I'd love to see this included in the core Magento package. Perhaps it may be considered if there's a stable release.

@jissereitsma
Copy link
Collaborator

I think the discussion of how to include this in the core is a different route: Most likely this involves talking with the right people, plus a major demand for this. Currently I myself classify this as a handy extension, not a neccessity. Theoretically I'd rather see it popup as a suggestion (which is possible in composer.json files) by some Magento developer tools package (as well as the suggestion to use the MSP DevTools and Mage2TV Cache Cleaner), instead of a solid requirement.

Another question is what needs to be done to make this a stable release. The word is misleading a bit because any package in composer that is not labeled as beta or alpha or rc would be stable as such. However, semantic versioning is another thing - version 1.0.0 would state a nice public release. For me, making that bump is a lot of times just based on feeling. To my feeling, to release version 1.0.0 tests under various circumstances would need to be done - wrong memory_limit, with and without XDebug enabled, performance testing and as a bare minimum, integration tests. I've added the latter two to the Issues. Hopefully I can pick up on this somewhere in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants