Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do detached children leak memory due to parent/child cycle #1

Closed
yjbanov opened this issue Mar 23, 2017 · 1 comment
Closed

Do detached children leak memory due to parent/child cycle #1

yjbanov opened this issue Mar 23, 2017 · 1 comment

Comments

@yjbanov
Copy link
Owner

yjbanov commented Mar 23, 2017

Reported by @mraleph. Reading the code, there should be a memory leak when detaching a sub-tree of RenderNodes. Despite Detach() nulling out _parent for the top-most detached child, the cycles inside the sub-tree should still prevent the destructors from being called. A quick speculative fix is to override Detach() in RenderMultiChildParent and call Detach() recursively on all live children.

@yjbanov
Copy link
Owner Author

yjbanov commented Mar 23, 2017

Or simply make child._parent a weak_ptr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant