feat(breadc): support no- boolean option

yjl9903 · Feb 25, 2023 · c94b26b · c94b26b
1 parent 0ac2ffa
commit c94b26b
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 5 deletions.
diff --git a/packages/breadc/src/option.ts b/packages/breadc/src/option.ts
@@ -17,15 +17,16 @@ export function makeOption<
   const match = OptionRE.exec(format);
   if (match) {
     name = match[2];
-    if (name.startsWith('no-')) {
-      throw new BreadcError(`Can not parse option format (${format})`);
-    }
 
     if (match[1]) {
       short = match[1][1];
     }
 
     if (match[3]) {
+      if (name.startsWith('no-')) {
+        throw new BreadcError(`Can not parse option format (${format})`);
+      }
+
       const initial = config.default ?? '';
       return <Option<F, T>>{
         format,
@@ -39,10 +40,17 @@ export function makeOption<
         cast: config.cast
       };
     } else {
+      if (name.startsWith('no-')) {
+        name = name.slice(3);
+        // @ts-ignore
+        config.default = true;
+      }
+
       const initial =
         config.default === undefined || config.default === null
           ? false
           : config.default;
+
       return <Option<F, T>>{
         format,
         type: 'boolean',

diff --git a/packages/breadc/test/breadc.test.ts b/packages/breadc/test/breadc.test.ts
@@ -279,8 +279,10 @@ describe('Breadc Error', () => {
     ).toThrowErrorMatchingInlineSnapshot(
       '"Can not parse option format (--root <...files>)"'
     );
-    expect(() => cli.option('--no-root')).toThrowErrorMatchingInlineSnapshot(
-      '"Can not parse option format (--no-root)"'
+    expect(() =>
+      cli.option('--no-root <root>')
+    ).toThrowErrorMatchingInlineSnapshot(
+      '"Can not parse option format (--no-root <root>)"'
     );
   });
 });

diff --git a/packages/breadc/test/command.test.ts b/packages/breadc/test/command.test.ts
@@ -205,6 +205,7 @@ describe('Help command', () => {
     const cli = breadc('cli');
     cli.option('--host <addr>', { description: 'Host address' });
     cli.option('-r, --remote', { description: 'Enable remote' });
+    cli.option('--no-open', { description: 'Open page' });
 
     expect(await cli.run(['-h'])).toMatchInlineSnapshot(`
       "cli/unknown

diff --git a/packages/breadc/test/parse.test.ts b/packages/breadc/test/parse.test.ts
@@ -407,6 +407,26 @@ describe('Option Parser', () => {
     `);
   });
 
+  it('should parse negtive boolean option', async () => {
+    const cli = breadc('cli');
+    cli.option('--no-open');
+    cli.command('').action((o) => o);
+
+    expect(await cli.run(['--open'])).toMatchInlineSnapshot(`
+      {
+        "--": [],
+        "open": true,
+      }
+    `);
+
+    expect(await cli.run(['--no-open'])).toMatchInlineSnapshot(`
+      {
+        "--": [],
+        "open": false,
+      }
+    `);
+  });
+
   it('should parse string option', async () => {
     const cli = breadc('cli');
     cli.option('--flag');