New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please don't set global random seed inside misc. function #7

Open

gwgundersen opened this issue Apr 21, 2021 · 0 comments

gwgundersen commented Apr 21, 2021

Thanks for taking the time to implement deep HMMs. However, this line of code, setting the random seed inside the data loader, is really unexpected:

https://github.com/yjlolo/pytorch-deep-markov-model/blob/master/base/base_data_loader.py#L35

I'd recommend the data loader takes a random number generator if you want this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment